Problem/Motivation

xxh3 is faster and more collision resistant than md5() and specifically designed for non-cryptographic use cases.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork cloudflare_purger-3606980

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

catch opened merge request !1

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review
bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
commented
Status: Needs review » Active

Agreed

bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
commented
Status: Active » Reviewed & tested by the community
luke.leber’s picture

luke.leber
Primary language English
Location Pennsylvania
commented

+1 for landing. Happy to update the test coverage MR afterwards.

bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
commented
Status: Reviewed & tested by the community » Fixed

Fixed an issue with the parenthesis and updated tests.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
commented

Note that for Luke and I who were using this with md5, cache invalidations will no longer work. Will have to manually clear the Cloudflare cache to force the new cache tags to be applied to pages in Cloudflare cache.

  • bkosborne committed 2535c009 on 1.0.x authored by catch 
    task: #3606980 Use xxh3 for hashing instead of md5()

By: catch
By:...
catch’s picture

catch
he/him
Primary language English
commented

Note that for Luke and I who were using this with md5, cache invalidations will no longer work. Will have to manually clear the Cloudflare cache to force the new cache tags to be applied to pages in Cloudflare cache.

Just a thought for future changes in case the format changes again, if we invalidated the 'http_response' cache tag in an update, in the old format, that should cover everything (but also ignore images/css/js etc.)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.