Problem/Motivation

When trying to run database updates, I get the following error:
[error] Search API sorts requires this module search_api and version >=1.16.
I am using search_api 1.41.0 which is what is specified in the info.yml.

Steps to reproduce

Proposed resolution

Remove search_api version from .info.yml file dependencies

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork search_api_sorts-3606451

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

shreya shetty created an issue. See original summary.

shreya shetty’s picture

shreya shetty commented
Status: Active » Needs review

peri22 opened merge request !16

peri22’s picture

peri22 commented
Status: Needs review » Reviewed & tested by the community

I opened MR !16 so the changes are visible in the issue queue. The code itself is exactly the same.
The current constraint fails if the installed `search_api` module doesn't have a version number in its `info.yml` (for example, when using a Git checkout or dev branch). In these cases, core checks an empty string and fails.
It is completely safe to remove this constraint because our `composer.json` already requires `drupal/search_api ^1.16`. Marking as RTBC!

ressa’s picture

ressa
he/him
commented

Thanks for looking at this @peri22, after your great work on Search API Sorts Widget. This parent-module has also seen reduced maintainer-activity recently, and dev-version is PHP 8.4-ready (see #3534957: PHP 8.4 compatibility), but has not yet been released. Perhaps this module is another candidate for you to become co-maintainer for, for example to commit this fix, and make a fresh release? :)

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Reviewed & tested by the community » Fixed

Merged to 8.x-1.x. Thanks!

It's been a while since I last used this module, so I don't regulary check the issue queue of this module, but try to keep up with core releases.
Help co-maintaining this module is always welcome.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • jeroent committed 5471cd99 on 8.x-1.x authored by peri22 
    fix: #3606451 Search API sorts unresolved dependency error

By: shreya...
peri22’s picture

peri22 commented

Thanks for merging these and for the 8.x-1.3 release!
I would love to help co-maintain this module. I worked on issues #3617951: Tabledraggers are missing for Search API Sorts module and #3618059: Test suite fails on 8.x-1.x with current Drupal core last week. I also co-maintain the "Search API sorts widget" module, which depends on this one, so keeping both in sync would be great.

I don't need release rights, Developer access is perfectly fine for me to review MRs, merge code, and keep the issue queue moving.

Best,
peri22