Problem/Motivation

doBulkRevisionable correctly slices processed IDs off revision_ids (lines 385-386) and refills when empty. doBulkNonRevisionable sets entity_ids on init and never modifies it again during processing. The actual entity loop uses a fresh query via current_id each call. So
entity_ids stays non-empty (for any site with entities), and the elseif refill branch never fires.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork entity_usage-3605887

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Reviewed & tested by the community

alexpott opened merge request !205

alexpott opened merge request !206

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 5.x-dev » 8.x-2.x-dev

  • alexpott committed a42380a8 on 5.x 
    task: #3605887 Clean up dead code in \Drupal\entity_usage\...

  • alexpott committed 0fee6d22 on 8.x-2.x 
    task: #3605887 Clean up dead code in \Drupal\entity_usage\...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.