Problem/Motivation

request to vimeo is performed with a fetch() with http:// protocol. Let's avoid mixed content rejections by using //

Issue fork ableplayer-3605802

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

gareth.poole created an issue. See original summary.

gareth.poole opened merge request !53

themusician’s picture

themusician commented

Thank you Gareth. It looks like this was updated as well in the release just 5 days ago of Able Player 5.0.0, https://github.com/ableplayer/ableplayer/releases/tag/v5.0.0. We'll look to get that tested, and if there are no issues, roll out a minor release.

themusician’s picture

themusician commented
Status: Active » Needs review

The current branch here has the latest Able Player 5.0 JS and CSS. This resolves the http error that was initially reported in my testing.

gareth.poole’s picture

gareth.poole
Location Wellington, New Zealand
commented

great! I'll test this today and mark it RTBC

gareth.poole’s picture

gareth.poole
Location Wellington, New Zealand
commented
Status: Needs review » Reviewed & tested by the community

themusician’s picture

themusician commented
Status: Reviewed & tested by the community » Fixed

Thank you Gareth for the help on the Installation test too.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

mably’s picture

mably commented

Just wanted to say that AblePlayer major version 5.0.0 introduces quite a few breaking changes:

https://ableplayer.github.io/ableplayer/changelog.html

Not sure it should have been changed in a patch version of the module.

We had to rollback to 3.4.2 in our case until we can update our custom integration code.

themusician’s picture

themusician commented

Thanks for bringing this up. Apologies for having things break.

In my testing I didn't notice any changes that affect how Able Player has been implemented in Drupal.

Was it translations-related that broke on your deployment?

I reviewed the breaking changes in 5.0.0 but didn't see anything the module implemented directly; it is just invoked through the library itself.

mably’s picture

mably commented

We enable AblePlayer after clicking on an image for performance and privacy reasons, this is done using the AblePlayer JavaScript API that has changed in 5.0.0.

themusician’s picture

themusician commented

I have added a disclaimer to the top of the project page regarding the changes in 5.0.0. Again, sincere apologies. I have always looked at the module semantic versioning as Drupal API breaking changes, not the library itself. I will be more careful moving forward and work to coordinate with the upstream project maintainer.

mably’s picture

mably commented

Hopefully that's not much of a change :)