Problem/Motivation

\Drupal\entity_usage\Plugin\EntityUsage\Track\TextFieldEmbedBase::getTargetEntities() checks to see if $item['value'] is empty and short circuits if it is. This is unnecessary because we're always checking that !$item->isEmpty() before calling this. It also results in inconsistent behaviour with text with summary fields.

Proposed resolution

Remove the code - it is not necessary.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork entity_usage-3605707

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexpott created an issue. See original summary.

alexpott opened merge request !200

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • alexpott committed 8d1eaa93 on 5.x 
    fix: #3605707 \Drupal\entity_usage\Plugin\EntityUsage\Track\...

  • alexpott committed e17af427 on 8.x-2.x 
    fix: #3605707 \Drupal\entity_usage\Plugin\EntityUsage\Track\...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.