Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork json_template-3604114

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

eleonel created an issue. See original summary.

eleonel opened merge request !4

radimklaska’s picture

radimklaska
Primary language Czech
Location 🇨🇿Czech Republic
commented
Status: Active » Reviewed & tested by the community

* reviewed MR !4 - adds || ^12 to core_version_requirement
* 4x ?AccountInterface nullable fixes in ListTemplateItem - needed on PHP 8.4+ (D12 runs PHP 8.5), matches the OptionsProviderInterface signatures
* plugin managers here are YAML defined, so no annotation discovery issue in D12

Looks good. RTBC.

  • eleonel committed 643816a3 on 1.x 
    Issue #3604114 by eleonel: Use explicit nullable parameter types...

  • eleonel committed c1da7d3b on 1.x 
    Issue #3604114 by eleonel: Add Drupal 12 to core_version_requirement.
eleonel’s picture

eleonel
he/him
Primary language Spanish
Location Itoshima 🇯🇵
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • eleonel committed 57047518 on 1.x 
    Issue #3604114 by eleonel: Replace REQUIREMENT_ERROR with...