In ExtractorQueue::processItem(), when extraction of the file contents succeeds, this happens:

      $fallback_collection = $this->keyValue->get(FilesExtractor::FALLBACK_QUEUE_KV);
      $fallback_collection->delete($data->entity_type . ':' . $data->entity_id);

However, that is not the structure of that collection, in FilesExtractor::queueItem() values are added like this:

      $queued_file_collection = $this->keyValue->get(static::FALLBACK_QUEUE_KV);
      $queued_files = $queued_file_collection->get($file->id());
      $queued_files[$entity->getEntityTypeId()][$entity->id()] = TRUE;
      $queued_file_collection->set($file->id(), $queued_files);

Therefore, it seems to me like entries will stay indefinitely in this fallback queue collection.

PS: I cannot set “10.0.x-dev” as the version as there is no dev snapshot release for that yet.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

drunken monkey created an issue. See original summary.

drunken monkey’s picture

Status: Active » Needs review

I created a merge request with what I think would be the correct code to use, please have a look.

  • izus committed 346b41a9 on 10.0.x authored by drunken monkey
    Resolve #3601364: Fix clean-up of queued files in ExtractorQueue::...
izus’s picture

Status: Needs review » Fixed

this is now merged.
thanks

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

izus’s picture

Status: Fixed » Closed (fixed)