Problem/Motivation

This is part of reducing waste outlined in #3580398: Skip on-commit jobs for the main and 11.x branches

The part is skipping known flakey tests to avoid having to re-run so many pipelines.

Steps to reproduce

Proposed resolution

Use the information at #2829040: [meta] Known intermittent, random, and environment-specific test failures to add skip the currently failing tests.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3600653

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone opened merge request !16055

quietone’s picture

quietone commented

There were two test failures on PHP 8.5. There were others on PHP8.6 which I did not look at.

1) MariaDB (via PDO): [8.5-ubuntu, mariadb-10.11]

Drupal\FunctionalTests\Bootstrap\UncaughtExceptionTest::testLostDatabaseConnection - 'Failed 3 times in the last 14 days"
This was supposed to have been fixed in #3521851: [random test failure] Drupal\FunctionalTests\Bootstrap\UncaughtExceptionTest::testLostDatabaseConnection

2) SQLite: [8.5-ubuntu, sqlite-3]
Nightwatch - core/modules/navigation/tests/src/Nightwatch/Tests/expandCollapseTest.js.

  • Expand/Collapse - narrow viewport
  • Expand/Collapse - wide viewport
  • browser. Failed 4 times in the last 14 days
catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review

https://git.drupalcode.org/project/drupal/-/jobs/10290130 is UncaughtExceptionTest which I think I've seen before.

quietone’s picture

quietone commented

The sqlite error can be seen at https://git.drupalcode.org/project/drupal/-/jobs/10289992#L2702

Is there a way to skip a nightwatch test?

is there a way to skip UncaughtExceptionTest::testLostDatabaseConnection for MariaDb?

catch’s picture

catch
he/him
Primary language English
commented

We could check the database driver in the method and return early I would think.

smustgrave’s picture

smustgrave commented

I must be super lucky as I don't think I've been hit by most of these.

What's a good way to review, just the eye test?

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Going with the eye test, and doesn't introduce any regression so this is impacting others makes sense.

catch’s picture

catch
he/him
Primary language English
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main, thanks!

Doesn't cherry-pick to 11.x but we don't run anywhere near as many MRs against 11.x so marking fixed for now.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • catch committed dcce147d on main 
    task: #3600653 Temporarily skip failing tests, round 2

By: quietone

catch closed merge request !16055

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.