Problem/Motivation

The content_lock.settings stored entity types that are not configured to be lockable. This creates a couple of issues in that visiting the form and pressing save after making no changes can result in config change and it means the queries to clean up system actions do more than necessary - plus the config is harder to reason about just by looking at it.

Steps to reproduce

Install the module - go to the config page and press save without making a change.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork content_lock-3599146

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
Issue tags: +Needs tests

We need to add test coverage of this change... especially the post update function.

alexpott opened merge request !118

idebr’s picture

idebr commented
Related issues: +#3534948: Content lock configuration does not account for bundle or entity types going away
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Issue tags: -Needs tests

  • alexpott committed 63d37f90 on 3.x 
    fix: #3599146 Remove entity types from config when they are not...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Thanks @idebr for pointing out that issue... this solves half of that one :)

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.