Problem/Motivation

A follow-up to #3593215: Simplify course start link hook logic, use first output only as we had a regression caused by lms_course_link hook invoke logic fault.
While figuring out how to add test coverage also noticed the StartLinkFieldItemList logic can be greatly simplified, we don't really need serialization / deserialization as all the logic can live in the view() method and computeValue() can set an empty string.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork lms-3595836

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

graber created an issue. See original summary.

graber’s picture

graber commented
Related issues: +#3593215: Simplify course start link hook logic, use first output only

graber opened merge request !187

graber’s picture

graber commented
Assigned: graber » Unassigned
Status: Active » Needs review

  • graber committed d5be26b0 on 1.1.x 
    #3595836: Simplified Start link field logic, added test coverage.

  • graber committed d5be26b0 on 1.2.x 
    #3595836: Simplified Start link field logic, added test coverage.
graber’s picture

graber commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.