Problem/Motivation

DefinedTermSet is used in Schema.org to represent a collection of defined terms, typically used in glossaries, taxonomies, etc. It works in conjunction with DefinedTerm, allowing structured representation of terminology sets and/or their individual entries.
Currently, support for this structure is missing.

Proposed resolution

Support both DefinedTerm and DefinedTermSet

see https://schema.org/DefinedTerm ,
https://schema.org/DefinedTermSet

CommentFileSizeAuthor
#8 schema_metatag-3595216-8.patch20.82 KBgresko8
#7 schema_metatag-3595216-7-MR120.patch22.09 KBanybody

Issue fork schema_metatag-3595216

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

joao.ramos.costa created an issue. See original summary.

joao.ramos.costa opened merge request !120

joao.ramos.costa’s picture

joao.ramos.costa commented
Status: Active » Needs review
joao.ramos.costa’s picture

joao.ramos.costa commented
Issue summary: View changes
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

Just came here with the same need for an FAQ - These are widely used for AIO / GEO. Code looks good, but I'm not an expert in this area, so maintainers should have a final look if everything is fine.

Thank you!!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

@joao.ramos.costa maybe you'd like to apply as co-maintainer here? Currently the module doesn't seem very actively maintained?

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
StatusFileSize
new schema_metatag-3595216-7-MR120.patch22.09 KB

Static patch attached until this is merged (hopefully soon :))

gresko8’s picture

gresko8 commented
StatusFileSize
new schema_metatag-3595216-8.patch20.82 KB

I think we should also include @id property for the DefinedTerm. Not sure if we want to include it here as this issue is already marked RTBC but I'm attaching a patch.

joao.ramos.costa’s picture

joao.ramos.costa commented

Hi @gresko, agree!

But feel free to commit to https://git.drupalcode.org/issue/schema_metatag-3595216/-/tree/3595216-d... !
I see you added id property to the DefinedTerm property, as it will be used in the DefinedTermSet, but in that case, the DefinedTerm metatag would benefit from the id property too, hence I think we should add the property there as well ? WDYT

joao.ramos.costa’s picture

joao.ramos.costa commented

Dear @anybody, thanks for testing and adding the patch.

I'm not sure I would be a good co-maintainer, since this was my first step into this schema metatag universe. Let me take some time to think about it and let the idea mature :)

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Thanks @joao.ramos.costa I'm maintainer now. This works like a charm, merging!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.