Problem/Motivation

The new glossary CSV-import feature validates that the uploaded CSV-file have exactly 2 columns. This is a problem if you export glossary CSV files from DeepL UI or from DeepL's glossary generator.

The CSV-files exported from DeepL contains 4 or 5 columns:

  1. Source term
  2. Target term
  3. Source language
  4. Target language
  5. Relevance (only in the glossary generator export)

Column 1 and 2 are the same as expected by the new CSV-import feature.

Steps to reproduce

  1. Create a glossary in DeepL UI and export it to CSV
  2. Create a new glossary from a TMX-file in DeepL' glossary generator and export the generated glossary to CSV.

Proposed resolution

Change the CSV-file validation from exactly 2 columns to at least 2 columns.

Issue fork tmgmt_deepl-3594398

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

beltofte created an issue. See original summary.

beltofte opened merge request !72

beltofte’s picture

beltofte
Primary language Danish
Location Copenhagen 🇩🇰
commented
Status: Active » Needs review

steffenr made their first commit to this issue’s fork.

steffenr’s picture

steffenr
Primary language German
Location Bremen
commented

@beltofte Thx again.
I've updated the phpunit test accordingly. The MR will be merged soon and i'll tag a new alpha release.

  • steffenr committed bd30d669 on 2.3.x authored by beltofte 
    fix: #3594398 Glossary CSV import does not accept CSV files exported...
steffenr’s picture

steffenr
Primary language German
Location Bremen
commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.