Problem/Motivation

Manually test the upgrade path from Telephone in core in current development branch to contrib in next major development branch works correctly..

Remaining tasks

Install Drupal current development branch on a machine with composer.

  1. composer create-project drupal/recommended-project:x.y.* drupal-telephone
  2. Go to the extension directory cd [drupal-telephone
  3. Enable development settings cp web/sites/example.settings.local.php web/sites/default/settings.local.php
  4. Add Drush composer require drush/drush
  5. Install Umami vendor/bin/drush si demo_umami
  6. Enable settings.local.php at the end of web/sites/default/settings.php

Enable and test

  1. Enable the extension vendor/bin/drush en -y telephone
  2. Test the extension functionality. Comment on what was tested.
  3. Confirm errors via update.php and warnings via drush updb about the missing core module.
Upgrade to contrib version and test
  1. composer require drupal/telephone
vendor/bin/drush cr
  2. Test the extension functionality. Comment on what was tested.

Upgrade to next major version and test

  1. composer config minimum-stability dev
composer require drupal/core-composer-scaffold:dev-main drupal/core-project-message:dev-main drupal/core-recommended:dev-main drush/drush -W
  2. Update to next major version Either:
    • Via the UI: visit update.php for the local test site
    • Via drush:
      vendor/bin/drush updb
vendor/bin/drush cr
  3. Confirm the core copy of Telephone is not present.
  4. Test
    • Test the extension functionality. Comment on what was tested.
    • Confirm errors admin/reports/status

Comments

quietone created an issue. See original summary.

smustgrave’s picture

smustgrave commented
Status: Postponed » Active

Should be able to be worked on now.

smustgrave’s picture

smustgrave commented

Tested this following the steps

composer create-project drupal/recommended-project:^11.3 telephone-upgrade, chose 11.3 because telephone has not been removed yet
cd telephone-upgrade
composer require drush/drush
I'm using ddev so did a ddev config
ddev drush si demo_umami
Enable Telephone module
Added a field to the Basic page content type
Created content with the Basic page and telephone renders just fine (well as it did before)

Now doing upgrade
composer config minimum-stability dev
composer config minimum-stability dev
composer require drupal/core-composer-scaffold:dev-main drupal/core-project-message:dev-main drupal/core-recommended:dev-main drush/drush -W
composer require drupal/telephone-telephone (had to use that as idk if the composer side is getting fixed anytime soon)
Updated .ddev/config to use 8.5
Ran ddev drush updb
ddev drush cr
Everything appears to be working as expected still. Only issue is that telephone-telephone but not sure I can fix it :(

Anything else I need to check?

shank115’s picture

shank115 commented

Ran through this too - nothing else to add on my end.

quietone’s picture

quietone commented

Tried this today and ddev composer require drupal/telephone fails with "Could not find a matching version of package drupal/telephone."

smustgrave’s picture

smustgrave commented

@quietone I noted that in #3 idk how to unblock the infrastructure team for working on that composer issue.

smustgrave’s picture

smustgrave commented
Status: Active » Reviewed & tested by the community

The composer issue landed! So this is working as expected anything else need to be done?

quietone’s picture

quietone commented
Status: Reviewed & tested by the community » Fixed

I just tested and can confirm this works as expected.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

quietone’s picture

quietone commented

composer require drupal/telephone-telephone (had to use that as idk if the composer side is getting fixed anytime soon)

I just noticed this line in the testing in #3. This test should be using drupal/telephone not drupal/telephone-telephone. That is the only way to confirm that the composer changes have been made and that sites don't have to know about package names like 'drupal/telephone-telephone'.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.