Problem/Motivation

Composer build is failing for "next major".

I think this is the problem area:

    - drupal/token_filter[2.1.0, ..., 2.1.x-dev] require drupal/core ^9.4 || ^10 -> satisfiable by drupal/core[9.4.0-alpha1, ..., 9.5.x-dev, 10.0.0-alpha1, ..., 10.6.x-dev].
    - drupal/token_filter[2.2.0, ..., 2.x-dev] require drupal/core ^10 || ^11 -> satisfiable by drupal/core[10.0.0-alpha1, ..., 10.6.x-dev, 11.0.0-alpha1, ..., 11.x-dev].

Failing because there isn't D12 compatible version of the Token Filter module.

Steps to reproduce

See pipeline.

Proposed resolution

I have opened an issue on Token Filter to add D12 support: #3593924: Add support for Drupal 12

We can use composer-lenient and composer-patch plugins to apply this change.

Remaining tasks

Extract Token Filter change as a patch.
Add to .gitlab-ci.yml.
Also add Upgrade Status check to .gitlab-ci.yml.
Check tests pass.

User interface changes

API changes

Data model changes

Issue fork smart_trim-3594018

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

lostcarpark created an issue. See original summary.

lostcarpark opened merge request !130

lostcarpark’s picture

lostcarpark commented

Generated patch from #3593924: Add support for Drupal 12 and added to .gitlab-ci, and set composer (next major) to apply it.

Composer is completing, and when we rebase for #3593272: Handle token hook implementations, everything should (hopefully) pass.

lostcarpark’s picture

lostcarpark commented
Status: Active » Needs review

Moving to needs review, though will need a rebase when #3593272: Handle token hook implementations merges.

ultimike made their first commit to this issue’s fork.

ultimike’s picture

ultimike
Primary language English
Location Florida, USA
commented
Status: Needs review » Needs work

I made some headway on this, but the PhpUnit (next major) is failing on tests/src/Functional/Update/SmartTrimUpdateMoreTest.php

I've rebased 2.x and added the ^12 core requirement to the info.yml file as well as updated some #[group()] attribute stuff.

-mike

lostcarpark’s picture

lostcarpark commented
Status: Needs work » Needs review

The problem is that SmartTrimUpdateMoreTest works by restoring a database and running the update script, but it can't update from a D10 database. I can rebuild the backup on D11. Will have to see if I can make it select the existing database for previous major, and the new one for later versions.

lostcarpark’s picture

lostcarpark commented

I have created a new fixture against 11.3. The setDatabaseDumpFiles function selects the appropriate fixture to load for the Drupal version. This one should be okay until we need to support D13.

Fixture created by loading the previous one into 11.3 codebase, and running updates. I needed to run against 2.0 branch of Smart Trim, so I had to cheat and add "^11" to the core version requirement to get the update to run.

All tests pass with the new fixture.

ultimike’s picture

ultimike
Primary language English
Location Florida, USA
commented
Status: Needs review » Fixed

Thank you, @lostcarpark, for your work on this issue!

I could have sworn that we had some documentation somewhere reminding us how to generate fixtures, but I can't find it. @lostcarpark - do you recall anything like this? @markie, do you?

I'm going to open a new issue (#3595211: Create tests/fixtures/README.md) to create a tests/fixtures/README.md to either link to the documentation I'm imagining or to add some instructions do so.

thanks,
-mike

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.