Problem/Motivation

Preserve this markup

Steps to reproduce

See markup, use wysiwyg ck5

<aside class="wb-fnote" role="note">
<h2 id="fn">Note</h2>

<dl>
	<dt>Note 1</dt>
	<dd id="fn1">
	<p>Lorem ipsum quarum</p>
	<p>Examples:</p>
	<ul>
		<li>equipment required</li>
		<li>an inspection required</li>
	</ul>

	<p class="fn-rtn"><a href="#fn1-rf"><span class="wb-inv">Return to footnote </span>1<span class="wb-inv"> referrer</span></a></p>
	</dd>
</dl>
</aside>

Proposed resolution

See commit

Remaining tasks

Commit code and release tag 1.0.1

User interface changes

See problem/motivation

API changes

See javascript and ckeditor5.yml file

Data model changes

N/A

Comments

joseph.olstad created an issue. See original summary.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Active » Needs review

  • joseph.olstad committed c4036ea7 on 1.0.x 
    fix: #3593956 Preserve related markup dd dt in another scenario

By:...
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

ok yet another case

<dl>
    <dt>
        Term
    </dt>
    <dd>
        Description
    </dd>
</dl>

Preserve this ^
AND also preserve this:

<dl>
    <dt>
        <p>Term</p>
    </dt>
    <dd>
        Description
    </dd>
</dl>

Prior to change, the p inside the dt would cause ckeditor5 to pop the dt out of the dl and only the p element would survive.

Fixed this now. See commit.

  • joseph.olstad committed 7e8beb64 on 1.0.x 
    fix: #3593956 Preserve related markup dd dt in another scenario

    By...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.