Problem/Motivation

At the moment the close_icon doesn't have alt text, but it should be.

Doc: https://dequeuniversity.com/rules/axe/4.11/image-alt?application=AxeChrome

Steps to reproduce

https://git.drupalcode.org/project/better_social_share/-/blob/1.1.x/temp...

Proposed resolution

<img alt="{{ 'Close icon'|t }}" src="{{ file_url(close_icon) }}" class="better-social-share-close">

Remaining tasks

Do the code change

User interface changes

nope

API changes

nope

Data model changes

nope

Issue fork better_social_share-3593849

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

csakiistvan created an issue. See original summary.

csakiistvan’s picture

csakiistvan
Primary language Hungarian
Location Budapest, Hungary
commented
Issue summary: View changes

csakiistvan changed the visibility of the branch 3593849-missing-alt-text to hidden.

csakiistvan opened merge request !8

csakiistvan’s picture

csakiistvan
Primary language Hungarian
Location Budapest, Hungary
commented
Status: Active » Needs review
csakiistvan’s picture

csakiistvan
Primary language Hungarian
Location Budapest, Hungary
commented
Assigned: csakiistvan » Unassigned
davidbp’s picture

davidbp commented
Assigned: Unassigned » davidbp
davidbp’s picture

davidbp commented
Assigned: davidbp » Unassigned
Status: Needs review » Reviewed & tested by the community

Looks good to me.

sujan shrestha’s picture

sujan shrestha commented
Status: Reviewed & tested by the community » Fixed

Hi @csakiistvan and @davidbp, Thank you for reporting and reviewing this issue.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.