Problem/Motivation

On `social-share-popup.html.twig` file contains a placeholder text what it is not translatable

https://git.drupalcode.org/project/better_social_share/-/blob/1.1.x/temp...

<input type="text" onkeyup="heateorSsspFilterSharing(this.value.trim())" placeholder="Search" class="social-share-search">

Steps to reproduce

Proposed resolution

Use `t` function here

<input type="text" onkeyup="heateorSsspFilterSharing(this.value.trim())" placeholder="{{ 'Search'|t }}" class="social-share-search">

Remaining tasks

Do the code change

User interface changes

nope

API changes

nope

Data model changes

nope

Issue fork better_social_share-3593848

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

csakiistvan created an issue. See original summary.

csakiistvan opened merge request !7

csakiistvan closed merge request !7

csakiistvan opened merge request !9

csakiistvan’s picture

csakiistvan
Primary language Hungarian
Location Budapest, Hungary
commented
Status: Active » Needs review
csakiistvan’s picture

csakiistvan
Primary language Hungarian
Location Budapest, Hungary
commented
Assigned: csakiistvan » Unassigned
davidbp’s picture

davidbp commented
Assigned: Unassigned » davidbp
davidbp’s picture

davidbp commented
Assigned: davidbp » Unassigned
Status: Needs review » Reviewed & tested by the community

Reviewed and looks good to me.

sujan shrestha’s picture

sujan shrestha commented
Status: Reviewed & tested by the community » Fixed

Hi @csakiistvan and @davidbp, Thanks for catching this and for the proposed fix.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.