Workspace Config should support Dupal Canvas.

Issue fork workspace_config-3593689

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

amateescu created an issue. See original summary.

amateescu opened merge request !1

amateescu’s picture

amateescu commented
Status: Active » Needs work

Started experimenting to see what it would take to support Canvas. Marking its config entity types as workspace-safe already goes a long way: I was able to edit a Page in a workspace, add a new Component, place that Component on the page, then publish the workspace.

The first problem I bumped into was that after placing a component in a page and publishing that page in Canvas, viewing the page didn't display the new component. After publishing the workspace, the component was still not displayed. So that would be the first thing to look into :)

  • amateescu committed 2357c83d on 1.0.x 
    task: #3593689 Add support for Drupal Canvas

By: amateescu
amateescu’s picture

amateescu commented
Status: Needs work » Fixed
Related issues: +#3594092: loadUnchanged() returns an in-memory-modified entity when hook_entity_preload() swaps in a non-default revision

That problem turned out to be a core bug: #3594092: loadUnchanged() returns an in-memory-modified entity when hook_entity_preload() swaps in a non-default revision

With that patch and the current MR applied, I couldn't find any other issues with Canvas!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.