Problem/Motivation

Child of #3584794: [meta] Convert core routes to PHP attributes

Steps to reproduce

Proposed resolution

Routing definitions for user.module controllers will be moved to attributes on the controller where possible.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3593667

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review

Maybe we want to wait for the form routing issue to land and expand on this.

longwave opened merge request !15987

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Looks like good conversions. The stacking of route attributes on top look weird.

Going to mark this as it might be good to get in as I know user.pass.http is trying to be deprecated to might be easier on them to have this worked out.

Will the deprecation go into the attribute?

quietone’s picture

quietone commented

I read the MR, comments and updated credit. I do agree with coding the conversion first, and then any follow ups to use aliases.

godotislate’s picture

godotislate
he/him
commented
Status: Reviewed & tested by the community » Needs work

#3584793: Use PHP attributes for form route discovery is in now, so let's do the form routes too per #2.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Routes look good. For the one mentioned @longwave should there be a follow up?

godotislate’s picture

godotislate
he/him
commented

For the one mentioned @longwave should there be a follow up?

Maybe people have other opinions, but I don't think it's worth moving AccountSettingsForm to the Form directory just so we can put a Route attribute on it.

smustgrave’s picture

smustgrave commented

No but maybe for consistency standard? I'm fine either way.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

I think we could do that in a followup if we wanted - it's better to be consistent so perhaps we should look for all forms that aren't in /Form/ and move them all at once.

  • godotislate committed 1f780ee5 on 11.x 
    task: #3593667 Convert user.module routes to attributes

By: longwave
By...

godotislate closed merge request !15987

  • godotislate committed 29066acd on main 
    task: #3593667 Convert user.module routes to attributes

By: longwave
By...
godotislate’s picture

godotislate
he/him
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 29066ac to main and 1f780ee to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.