Problem/Motivation

The composer.json of domain_access_search_api requires "drupal/domain": "^2.0.0". With the release of domain 3.0.x, this constraint prevents installation alongside the latest Domain module version.

The module itself contains no code that is incompatible with domain 3.x. Only the Composer constraint needs updating.

Steps to reproduce

  1. Have a Drupal project requiring drupal/domain: ^3.0.
  2. Run composer require drupal/domain_access_search_api:^1.0.
  3. Composer fails with a version conflict because domain_access_search_api 1.0.6 requires drupal/domain: ^2.0.0.

Proposed resolution

Update the require section in composer.json to allow both Domain 2.x and 3.x:

{
    "name": "drupal/domain_access_search_api",
    "description": "Creates a Views filter to filter by domain.",
    "type": "drupal-module",
    "license": "GPL-2.0-or-later",
    "require": {
        "drupal/domain": "^2.0.0 || ^3.0.0",
        "drupal/search_api": "^1.38"
    }
}

No source code changes are required.

Remaining tasks

  • Create a MR containing the changes.

User interface changes

None.

API changes

None.

Data model changes

None.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

steffenr created an issue. See original summary.

steffenr’s picture

Assigned: steffenr » Unassigned
Status: Active » Needs review

  • steffenr committed 670f3681 on 1.0.x
    Issue #3593637: Add domain 3.x compatibility to composer.json
    
andileco’s picture

Status: Needs review » Fixed

Thanks for your contribution!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

pfructuoso’s picture

please, realease it!

andileco’s picture

Will do now. Sorry for the delay. I was hoping to have time to incorporate: https://www.drupal.org/project/domain_access_search_api/issues/3446056, but that didn't happen.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.