Problem/Motivation

When I go into my text format and turn off customize headings (after I have already added some custom headings), the custom headings still override the default headings.

Steps to reproduce

  1. Enable module
  2. Enable 'customize headings' for one of my text formats
  3. Add some custom headings and save the text format
  4. Disable 'customize headings' for my text format
  5. Try to use that text format and see that it is still using the custom headings, rather than the default ones

Proposed resolution

We could get rid of the customize headings toggle all-together, and just have this module update the text format config when it is enabled or disabled. This would especially make sense with the other issue I raised about making sure to have default headings available in the custom headings config by default when the module is enabled: https://www.drupal.org/project/ckeditor_custom_headings/issues/3593361

CommentFileSizeAuthor
#4 3593370-custom-headings-override.patch768 bytesdkmishra

Issue fork ckeditor_custom_headings-3593370

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

megakeegman created an issue. See original summary.

dkmishra made their first commit to this issue’s fork.

dkmishra opened merge request !1

dkmishra’s picture

dkmishra commented
Version: 1.0.0 » 1.x-dev
Status: Active » Needs review
StatusFileSize
new 3593370-custom-headings-override.patch768 bytes

Patch attached

dieterholvoet’s picture

dieterholvoet commented
Status: Needs review » Reviewed & tested by the community

Tested, works great. Thanks for the contribution!

dieterholvoet’s picture

dieterholvoet commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.