I have a search View and I want to change the "Preserve facets while using filters", which has nothing to do with Searchstax. But there's a Searchstax section on the same settings form that is preventing me form updating the setting I want to update.
Try to change a query setting on a View that integrates with Searchstax.
The workaround is to enter a bogus username/password combination, which is good enough for the form to validate and save. But I shouldn't have to do that.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | Screenshot 2026-06-05 at 11.49.04 AM.png | 61.53 KB | danflanagan8 |
| Screenshot 2026-06-02 at 11.09.29 AM.png | 89.89 KB | danflanagan8 |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
drunken monkeyThanks for reporting this problem!
You’re of course correct, this behavior is annoying and doesn’t make any sense. We should just be able to set those two fields to non-required and let the login form (if “Continue” is clicked) complain about wrong login if any fields are left empty.
Implemented in this MR, please give it a try!
Comment #5
danflanagan8Would it makes sense to add a new argument to
ApiLoginFormTrait::showLogInForm()to allow setting the username and password as not required?Not sure how often this pattern would be used, but it might be more elegant than following that call with the foreach block.
Either way this looks like it should work. Nice job throwing in the test coverage.
Comment #6
drunken monkey@danflanagan8 #5: Good suggestion, thanks. After a bit of consideration, given that this is currently used only once I think I’ll leave the code as-is, though. We can always change this later if it occurs a second time. The code right now might not be the most elegant, but it’s concise enough.
Could you give the MR a try to see if it really works for you? Then I could merge this, making it part of the next release (probably next week).
Comment #7
danflanagan8I applied the change in the MR to my local and it fixed the problem.
The Searchstax fields are no longer required and I can submit my other changes to the form.
Thanks for the fix, @drunken monkey
Comment #9
drunken monkeyGreat to hear, thanks for testing!
Merged.
Thanks again!