Problem/Motivation

There are a few areas in the module that need modernization and configuration fixes to align with current Drupal standards and best practices:

  • Plugin Discovery: The DynamicSubscriptions plugin currently uses Doctrine annotations instead of native PHP 8 attributes.
  • Missing schema configuration: The subscription_plan_id property is missing from the module's configuration schema.
  • Missing logger channel: The module lacks a dedicated logger channel service to properly categorize and track its log events.

Proposed resolution

  • Update the minimum core requirement to ^10.2 to safely support PHP 8 attributes.
  • Refactor DynamicSubscriptions.php to use the PHP attribute syntax.
  • Add the subscription_plan_id property to commerce_paypal_dynamic_subscriptions.schema.yml.
  • Define the logger.channel.commerce_paypal_dynamic_subscriptions service.
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

dimaro created an issue. See original summary.

dimaro’s picture

Assigned: dimaro » Unassigned
Status: Active » Reviewed & tested by the community

Created Merge request: https://git.drupalcode.org/project/commerce_paypal_dynamic_subscriptions... . Skipping community / maintainer review because this was written by a maintainer.

  • dimaro committed 55cebc75 on 1.x
    Issue: #3593120 Use PHP Attribute syntax instead of Annotations + Fix...
dimaro’s picture

Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.