Problem/Motivation

The confirmation email doesn't set a default format. This causes the form to fail to save until all formats have been given a default.

However, the override fields should not appear at all until the override checkbox is ticked.

Steps to reproduce

Proposed resolution

Get the default format for the site and any format drop-down that don't have a value set.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork conreg-3592461

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

lostcarpark created an issue. See original summary.

tribekk made their first commit to this issue’s fork.

tribekk opened merge request !44

tribekk’s picture

tribekk commented
Status: Active » Needs review

Opened MR !44.

The member type confirmation override body now falls back to the default text format when an existing member type has no stored format. The subject and body fields are hidden until override is selected.

Added a form build test for the fallback format and visibility states.

Checked locally:
- php -l src/Form/Admin/MemberTypes.php
- php -l tests/src/Kernel/FormBuildTest.php
- composer validate --no-check-publish
- git diff --check

lostcarpark’s picture

lostcarpark commented
Status: Needs review » Reviewed & tested by the community

Tested and it's working great.

We'll need to revisit later as filter_default_format() will be deprecated in 11.4 and removed in 13.

Moving to RTBC.

  • lostcarpark committed 9f2f2fe9 on 1.x authored by tribekk 
    feat: #3592461 Set default format and hide when not needed on override...
lostcarpark’s picture

lostcarpark commented
Status: Reviewed & tested by the community » Fixed

Thanks for working on this @tribekk.

Merged and moving to Fixed.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.