Problem/Motivation

Default Admin should be marked beta. Most of the work remaining is reducing technical debt. Releasing the theme as experimental earlier would allow us to get more early testing on it before Drupal 12 where we are planning to remove Claro.

Proposed resolution

The git hash where default_admin was 2e658715f940d1fe6260bc7a4e0f99ff7cf15d4a.

Per @catch, steps are:

  1. It should be git show hash > remove.patch
  2. Manually delete lines from the patch for anything that's staying removed.
  3. patch -p1 -R < remove.patch
  4. git add -p
  5. Give or take phpstan and things.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3592406

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

lauriii created an issue. See original summary.

lauriii opened merge request !15912

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Active » Needs review
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
Issue tags: +11.4.0 release highlights

I manually verified the contents of this MR.

  1. I added the remote and checked out the branch.
  2. Then I ran git show 2e658715f940d1fe6260bc7a4e0f99ff7cf15d4a > remove.patch (this was the hash of the removal commit)
  3. Then I ran git apply --reject -p1 < remove.patch
  4. I got all of core/themes/default_admin/... cleanly
  5. These were the only errors in the output:
    Checking patch core/modules/mailer/mailer.info.yml...
error: core/modules/mailer/mailer.info.yml: No such file or directory
Checking patch core/modules/mailer/mailer.services.yml...
error: core/modules/mailer/mailer.services.yml: No such file or directory
Checking patch core/modules/mailer/src/Hook/MailerHooks.php...
error: core/modules/mailer/src/Hook/MailerHooks.php: No such file or directory
Checking patch core/modules/mailer/tests/modules/mailer_capture/mailer_capture.info.yml...
error: core/modules/mailer/tests/modules/mailer_capture/mailer_capture.info.yml: No such file or directory
Checking patch core/modules/mailer/tests/modules/mailer_capture/src/MailerCaptureServiceProvider.php...
error: core/modules/mailer/tests/modules/mailer_capture/src/MailerCaptureServiceProvider.php: No such file or directory
Checking patch core/modules/mailer/tests/modules/mailer_capture/src/Transport/CaptureTransport.php...
error: core/modules/mailer/tests/modules/mailer_capture/src/Transport/CaptureTransport.php: No such file or directory
Checking patch core/modules/mailer/tests/modules/mailer_capture_test/mailer_capture_test.info.yml...
error: core/modules/mailer/tests/modules/mailer_capture_test/mailer_capture_test.info.yml: No such file or directory
Checking patch core/modules/mailer/tests/modules/mailer_capture_test/mailer_capture_test.routing.yml...
error: core/modules/mailer/tests/modules/mailer_capture_test/mailer_capture_test.routing.yml: No such file or directory
Checking patch core/modules/mailer/tests/modules/mailer_capture_test/src/Form/MailerCaptureTestForm.php...
error: core/modules/mailer/tests/modules/mailer_capture_test/src/Form/MailerCaptureTestForm.php: No such file or directory
Checking patch core/modules/mailer/tests/modules/mailer_event_subscriber_test/mailer_event_subscriber_test.info.yml...
error: core/modules/mailer/tests/modules/mailer_event_subscriber_test/mailer_event_subscriber_test.info.yml: No such file or directory
Checking patch core/modules/mailer/tests/modules/mailer_event_subscriber_test/mailer_event_subscriber_test.services.yml...
error: core/modules/mailer/tests/modules/mailer_event_subscriber_test/mailer_event_subscriber_test.services.yml: No such file or directory
Checking patch core/modules/mailer/tests/modules/mailer_event_subscriber_test/src/EventSubscriber/MessageEventTestSubscriber.php...
error: core/modules/mailer/tests/modules/mailer_event_subscriber_test/src/EventSubscriber/MessageEventTestSubscriber.php: No such file or directory
Checking patch core/modules/mailer/tests/modules/mailer_transport_factory_functional_test/mailer_transport_factory_functional_test.info.yml...
error: core/modules/mailer/tests/modules/mailer_transport_factory_functional_test/mailer_transport_factory_functional_test.info.yml: No such file or directory
Checking patch core/modules/mailer/tests/modules/mailer_transport_factory_functional_test/mailer_transport_factory_functional_test.routing.yml...
error: core/modules/mailer/tests/modules/mailer_transport_factory_functional_test/mailer_transport_factory_functional_test.routing.yml: No such file or directory
Checking patch core/modules/mailer/tests/modules/mailer_transport_factory_functional_test/src/Controller/TransportInfoController.php...
error: core/modules/mailer/tests/modules/mailer_transport_factory_functional_test/src/Controller/TransportInfoController.php: No such file or directory
Checking patch core/modules/mailer/tests/modules/mailer_transport_factory_kernel_test/mailer_transport_factory_kernel_test.info.yml...
error: core/modules/mailer/tests/modules/mailer_transport_factory_kernel_test/mailer_transport_factory_kernel_test.info.yml: No such file or directory
Checking patch core/modules/mailer/tests/modules/mailer_transport_factory_kernel_test/mailer_transport_factory_kernel_test.services.yml...
error: core/modules/mailer/tests/modules/mailer_transport_factory_kernel_test/mailer_transport_factory_kernel_test.services.yml: No such file or directory
Checking patch core/modules/mailer/tests/modules/mailer_transport_factory_kernel_test/src/Transport/CanaryTransport.php...
error: core/modules/mailer/tests/modules/mailer_transport_factory_kernel_test/src/Transport/CanaryTransport.php: No such file or directory
Checking patch core/modules/mailer/tests/modules/mailer_transport_factory_kernel_test/src/Transport/CanaryTransportFactory.php...
error: core/modules/mailer/tests/modules/mailer_transport_factory_kernel_test/src/Transport/CanaryTransportFactory.php: No such file or directory
Checking patch core/modules/mailer/tests/src/Functional/GenericTest.php...
error: core/modules/mailer/tests/src/Functional/GenericTest.php: No such file or directory
Checking patch core/modules/mailer/tests/src/Functional/MailerCaptureTest.php...
error: core/modules/mailer/tests/src/Functional/MailerCaptureTest.php: No such file or directory
Checking patch core/modules/mailer/tests/src/Functional/TransportServiceFactoryTest.php...
error: core/modules/mailer/tests/src/Functional/TransportServiceFactoryTest.php: No such file or directory
Checking patch core/modules/mailer/tests/src/Kernel/OriginatorSubscriberTest.php...
error: core/modules/mailer/tests/src/Kernel/OriginatorSubscriberTest.php: No such file or directory
Checking patch core/modules/mailer/tests/src/Kernel/TransportTest.php...
error: core/modules/mailer/tests/src/Kernel/TransportTest.php: No such file or directory
  6. After this ls core/themes lists no default_admin theme so all related files were removed.

I think this is sufficient to say that the MR restores extractly the default_admin part of the revert MR. Would be useful to merge ASAP so any non-backported MRs can still be backported.

  • longwave committed d8905dd3 on 11.4.x 
    task: #3592406 Mark Default Admin beta and revert the revert

By:...
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Fixed

Let's do it.

Committed d8905dd and pushed to 11.4.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

longwave closed merge request !15912

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.