Problem/Motivation

RevisionCount extends NodeCount but doesn't actually return the number of revisions.

Steps to reproduce

Proposed resolution

  • Fix RevisionCount collector to properly override getCount() method and call allRevisions() on the query
  • Add unit test for RevisionCount collector

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork prometheus_exporter-3591486

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kim.pepper created an issue. See original summary.

  • kim.pepper committed e88ea744 on 2.x 
    Revert "fix: #3591486 RevisionCount is broken"

This reverts commit...

kim.pepper opened merge request !26

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Status: Active » Needs review

I accidentally pushed this to the 2.x branch and then reverted.

This MR is ready for reviews.

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Issue summary: View changes
kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Title: RevisionCount is broken » RevisionCount is broken after NodeCount refactor

  • kim.pepper committed e00e181b on 2.x 
    fix: #3591486 RevisionCount is broken after NodeCount refactor

By: kim....
kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Status: Needs review » Fixed

Committed to 2.x

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.