Problem/Motivation

Current component download block do not match the documentation, and seems totally outdated.

We should mark it as deprecated and offer a proper download card that match documentation and avoid duplication of the card markup.

API changes

Mark download block as deprecated.

Issue fork ui_suite_dsfr-3591052

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mogtofu33 created an issue. See original summary.

mogtofu33’s picture

mogtofu33 commented
Version: 1.1.x-dev » 1.14.2

mogtofu33 changed the visibility of the branch 3591052-download-card to hidden.

mogtofu33 opened merge request !202

mogtofu33’s picture

mogtofu33 commented
Assigned: Unassigned » just_like_good_vibes
Status: Active » Needs review
just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Assigned: just_like_good_vibes » Unassigned
Status: Needs review » Closed (duplicate)

Hello, you are right, the download block uses old markup.

But the DSFR has no download card component. The download card is an option of the card, so it belongs on our card component as a prop, not in a new component.

I opened #3620116: Add the download variants to link, card and tile to do it all at once: the download option on link, card and tile, and the three old components rewritten on top of them, so existing displays keep working.

Closing as a duplicate. Thanks for raising it.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.