Overview

Current version of `justinrainbow/json-schema` has not JSON schema Draft-07 support, so we are tied with Draft-04.
On the other hand, we use Ajv in the front-end UI, which doesn't support Draft-04 by default. See https://ajv.js.org/guide/schema-language.html#draft-04

Proposed resolution

Bump justinrainbow/json-schema to ~6.8.0 for JSON Schema Draft-07 support.

Core is doing that in #3352063: Allow schema references in Single Directory Component prop schemas

User interface changes

None

Issue fork canvas-3591028

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

penyaskito created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Component: Code » Shape matching

WFM 👍

Insta-approval upon green MR.

penyaskito opened merge request !1129

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Bump `justinrainbow/json-schema` to ~6.8.0 for JSON schema draft-07 support » Bump `justinrainbow/json-schema` to ~6.8.0 for JSON schema draft-07 support, and use it consistently in both back and front end
Priority: Normal » Major
Status: Active » Reviewed & tested by the community
Issue tags: +technical debt

👏 Kudos for making this consistent across back end and front end! This is one of those things where you wonder how we ever got this far without doing this 😅🙈

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Title: Bump `justinrainbow/json-schema` to ~6.8.0 for JSON schema draft-07 support, and use it consistently in both back and front end » Consistently use JSON-Schema Draft-07 dialect in frontend and backend by updating `justinrainbow/json-schema` to ^6.8.0

  • penyaskito committed e92d2404 on 1.x 
    chore(Shape matching): #3591028 Consistently use JSON-Schema Draft-07...
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.