Problem/Motivation

We are missing some utilities from documentation:

Some fixes on the library (for UI Styles library and Display builder):

  • Proper DSFR side menu
  • Spacing clockwork order
  • Better order overall
  • Better preview classes for spacing (background and border)
  • Some minor preview fixes

Issue fork ui_suite_dsfr-3590803

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mogtofu33 created an issue. See original summary.

mogtofu33 opened merge request !200

mogtofu33’s picture

mogtofu33 commented
Assigned: Unassigned » just_like_good_vibes
Status: Active » Needs review
just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Assigned: just_like_good_vibes » pdureau

in my understanding of the role of this theme, we should follow the upstream and implement as close as possible what is provided and what is not provided. In that context i am not in favor to the addition of css utilities. we better discuss that point between all maintainers.

i keep the needs review state and pass it to another maintainer for advice

mogtofu33’s picture

mogtofu33 commented
Assigned: pdureau » just_like_good_vibes

Ok, removed border and print, keep shadow and visibility as they are part of the upstream.
And a minor display builder css fix.

mogtofu33’s picture

mogtofu33 commented
Title: Add some missing utilities » Add missing shadow and visibility from upstream
Issue summary: View changes
mogtofu33’s picture

mogtofu33 commented
Title: Add missing shadow and visibility from upstream » Add missing utilities from upstream
Assigned: just_like_good_vibes » mogtofu33
Issue summary: View changes
Status: Needs review » Needs work
mogtofu33’s picture

mogtofu33 commented
Issue summary: View changes
mogtofu33’s picture

mogtofu33 commented
Assigned: mogtofu33 » just_like_good_vibes
Status: Needs work » Needs review
mogtofu33’s picture

mogtofu33 commented
Issue summary: View changes

just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Assigned: just_like_good_vibes » Unassigned
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.