Problem/Motivation

This is not an entirely obvious candidate for a kernel test because it relies on logging users in for several methods, although possibly that could be handled by changing permissions on the anonymous account.

We can save a bit of time by consolidating three test methods into one - it's a cumulative test in the end anyway.

One of the slowest functional tests, e.g. 200s on this job: https://git.drupalcode.org/project/drupal/-/jobs/9865552

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3590746

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review

Local times:

Before:

Time: 01:07.679, Memory: 14.00 MB

OK (12 tests, 73 assertions)

After:

Time: 00:55.118, Memory: 14.00 MB

OK (9 tests, 70 assertions)

catch opened merge request !15799

catch’s picture

catch
he/him
Primary language English
commented
Issue summary: View changes
catch’s picture

catch
he/him
Primary language English
commented

After job on gitlab:

62.972s Drupal\FunctionalTests\Entity\RevisionVersionHistoryTest 9 passed

https://git.drupalcode.org/project/drupal/-/jobs/9866669

catch’s picture

catch
he/him
Primary language English
commented
Issue tags: +Test suite performance
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Seems like a good refactor to me based on #2 output.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 50ebb80ed0f to main and 390140a3a97 to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • alexpott committed 390140a3 on 11.x 
    perf: #3590746 Speed up RevisionVersionHistoryTest

By: catch
(cherry...

  • alexpott committed 50ebb80e on main 
    perf: #3590746 Speed up RevisionVersionHistoryTest

By: catch

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.