Problem/Motivation

Some new PHPStan issues appeared. let's fix them.
But an important point is that they are drupal 11 related. If we keep drupal 10 +11 compatibility, we need to tackle this in a nice way

------ ----------------------------------------------------------------------- 
  Line   theme-settings.php                                                     
 ------ ----------------------------------------------------------------------- 
  26     Call to deprecated function theme_get_setting():                       
         in drupal:11.3.0 and is removed from drupal:13.0.0. Use                
                                                                                
         \Drupal::service('Drupal\Core\Extension\ThemeSettingsProvider')->getS  
         etting()                                                               
           instead.                                                             
         🪪  function.deprecated                                                
  41     Call to deprecated function theme_get_setting():                       
         in drupal:11.3.0 and is removed from drupal:13.0.0. Use                
                                                                                
         \Drupal::service('Drupal\Core\Extension\ThemeSettingsProvider')->getS  
         etting()                                                               
           instead.                                                             
         🪪  function.deprecated                                                
  50     Call to deprecated function theme_get_setting():                       
         in drupal:11.3.0 and is removed from drupal:13.0.0. Use                
                                                                                
         \Drupal::service('Drupal\Core\Extension\ThemeSettingsProvider')->getS  
         etting()                                                               
           instead.                                                             
         🪪  function.deprecated                                                
  56     Call to deprecated function theme_get_setting():                       
         in drupal:11.3.0 and is removed from drupal:13.0.0. Use                
                                                                                
         \Drupal::service('Drupal\Core\Extension\ThemeSettingsProvider')->getS  
         etting()                                                               
           instead.                                                             
         🪪  function.deprecated                                                
  61     Call to deprecated function theme_get_setting():                       
         in drupal:11.3.0 and is removed from drupal:13.0.0. Use                
                                                                                
         \Drupal::service('Drupal\Core\Extension\ThemeSettingsProvider')->getS  
         etting()                                                               
           instead.                                                             
         🪪  function.deprecated                                                
  66     Call to deprecated function theme_get_setting():                       
         in drupal:11.3.0 and is removed from drupal:13.0.0. Use                
                                                                                
         \Drupal::service('Drupal\Core\Extension\ThemeSettingsProvider')->getS  
         etting()                                                               
           instead.                                                             
         🪪  function.deprecated                                                
  71     Call to deprecated function theme_get_setting():                       
         in drupal:11.3.0 and is removed from drupal:13.0.0. Use                
                                                                                
         \Drupal::service('Drupal\Core\Extension\ThemeSettingsProvider')->getS  
         etting()                                                               
           instead.                                                             
         🪪  function.deprecated                                                
  75     Call to deprecated function theme_get_setting():                       
         in drupal:11.3.0 and is removed from drupal:13.0.0. Use                
                                                                                
         \Drupal::service('Drupal\Core\Extension\ThemeSettingsProvider')->getS  
         etting()                                                               
           instead.                                                             
         🪪  function.deprecated                                                
  79     Call to deprecated function theme_get_setting():                       
         in drupal:11.3.0 and is removed from drupal:13.0.0. Use                
                                                                                
         \Drupal::service('Drupal\Core\Extension\ThemeSettingsProvider')->getS  
         etting()                                                               
           instead.                                                             
         🪪  function.deprecated                                                
 ------ ----------------------------------------------------------------------- 
 ------ ----------------------------------------------------------------------- 
  Line   ui_suite_dsfr.theme                                                    
 ------ ----------------------------------------------------------------------- 
  22     Call to deprecated function theme_get_setting():                       
         in drupal:11.3.0 and is removed from drupal:13.0.0. Use                
                                                                                
         \Drupal::service('Drupal\Core\Extension\ThemeSettingsProvider')->getS  
         etting()                                                               
           instead.                                                             
         🪪  function.deprecated                                                
  23     Call to deprecated function theme_get_setting():                       
         in drupal:11.3.0 and is removed from drupal:13.0.0. Use                
                                                                                
         \Drupal::service('Drupal\Core\Extension\ThemeSettingsProvider')->getS  
         etting()                                                               
           instead.                                                             
         🪪  function.deprecated                                                
  25     Call to deprecated function theme_get_setting():                       
         in drupal:11.3.0 and is removed from drupal:13.0.0. Use                
                                                                                
         \Drupal::service('Drupal\Core\Extension\ThemeSettingsProvider')->getS  
         etting()                                                               
           instead.                                                             
         🪪  function.deprecated                                                
  26     Call to deprecated function theme_get_setting():                       
         in drupal:11.3.0 and is removed from drupal:13.0.0. Use                
                                                                                
         \Drupal::service('Drupal\Core\Extension\ThemeSettingsProvider')->getS  
         etting()                                                               
           instead.                                                             
         🪪  function.deprecated                                                
  27     Call to deprecated function theme_get_setting():                       
         in drupal:11.3.0 and is removed from drupal:13.0.0. Use                
                                                                                
         \Drupal::service('Drupal\Core\Extension\ThemeSettingsProvider')->getS  
         etting()                                                               
           instead.                                                             
         🪪  function.deprecated                                                
  35     Call to deprecated function theme_get_setting():                       
         in drupal:11.3.0 and is removed from drupal:13.0.0. Use                
                                                                                
         \Drupal::service('Drupal\Core\Extension\ThemeSettingsProvider')->getS  
         etting()                                                               
           instead.                                                             
         🪪  function.deprecated                                                
  36     Call to deprecated function theme_get_setting():                       
         in drupal:11.3.0 and is removed from drupal:13.0.0. Use                
                                                                                
         \Drupal::service('Drupal\Core\Extension\ThemeSettingsProvider')->getS  
         etting()                                                               
           instead.                                                             
         🪪  function.deprecated                                                
  38     Call to deprecated function theme_get_setting():                       
         in drupal:11.3.0 and is removed from drupal:13.0.0. Use                
                                                                                
         \Drupal::service('Drupal\Core\Extension\ThemeSettingsProvider')->getS  
         etting()                                                               
           instead.                                                             
         🪪  function.deprecated                                                
  39     Call to deprecated function theme_get_setting():                       
         in drupal:11.3.0 and is removed from drupal:13.0.0. Use                
                                                                                
         \Drupal::service('Drupal\Core\Extension\ThemeSettingsProvider')->getS  
         etting()                                                               
           instead.                                                             
         🪪  function.deprecated                                                
  41     Call to deprecated function theme_get_setting():                       
         in drupal:11.3.0 and is removed from drupal:13.0.0. Use                
                                                                                
         \Drupal::service('Drupal\Core\Extension\ThemeSettingsProvider')->getS  
         etting()                                                               
           instead.                                                             
         🪪  function.deprecated                                                
  42     Call to deprecated function theme_get_setting():                       
         in drupal:11.3.0 and is removed from drupal:13.0.0. Use                
                                                                                
         \Drupal::service('Drupal\Core\Extension\ThemeSettingsProvider')->getS  
         etting()                                                               
           instead.                                                             
         🪪  function.deprecated                                                
  365    Call to deprecated function theme_get_setting():                       
         in drupal:11.3.0 and is removed from drupal:13.0.0. Use                
                                                                                
         \Drupal::service('Drupal\Core\Extension\ThemeSettingsProvider')->getS  
         etting()                                                               
           instead.                                                             
         🪪  function.deprecated                                                
 ------ ----------------------------------------------------------------------- 
 [ERROR] Found 21 errors

Issue fork ui_suite_dsfr-3590635

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

just_like_good_vibes created an issue. See original summary.

just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented

for now, we will keep support of drupal 10&11 and we do not introduce two separate ui_suite_dsfr versions (like one for drupal 10 only and another for drupal 11 with the code up to date with the use of the new service replacing the deprecated function theme_get_settings).

once drupal 10 reachs EOL, we will drop support of drual 10 and update the deprecated code.
For now, we will ignore the deprecated warnings treated as errors and blocking the pipeline.

so we have several ways of doing that. Given the fact we have no phpstan.neon right now, and that this project is a theme,
we decided, for now, allow failures of phpstan in the pipeline. Deprecated code will still show failures, but our pipelines won't be blocked.

we could have tweaked the launch of phpstan (with previous major, next major..etc) or introduced a custom phpstan.neon, but we don't do that for now.

just_like_good_vibes opened merge request !198

just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Title: Fix phpstan new issue » Ignore phpstan deprecation errors blocking the CI pipeline

just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Assigned: just_like_good_vibes » Unassigned
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.