Problem/Motivation

The Horizontal Ruler component name no longer reflects what the component does.

Proposed resolution

Rename the Horizontal Ruler component to Divider.

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes
  • ✅ Release varbase-11.0.0-alpha3, varbase_starter-1.0.0-alpha2, vartheme_bs5-5.0.0-alpha3

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • chore: #3590568 Change Horizontal Ruler component to Divider component

Issue fork vartheme_bs5-3590568

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alamgir.hossain.cse created an issue. See original summary.

alamgir.hossain.cse opened merge request !156

alamgir.hossain.cse’s picture

alamgir.hossain.cse commented
Status: Active » Needs review
alamgir.hossain.cse’s picture

alamgir.hossain.cse commented
Status: Needs review » Active
alamgir.hossain.cse’s picture

alamgir.hossain.cse commented
Status: Active » Needs review

rajab natshah made their first commit to this issue’s fork.

rajab natshah’s picture

rajab natshah
he/him
commented
Title: Spacer Component Changed to Divider » Change Horizontal Ruler Component to Divider component
rajab natshah’s picture

rajab natshah
he/him
commented
Title: Change Horizontal Ruler Component to Divider component » Rename Horizontal Ruler Component to Divider component
rajab natshah’s picture

rajab natshah
he/him
commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rajab natshah’s picture

rajab natshah
he/him
commented
Issue tags: +varbase-11.0.0-alpha3, +varbase_starter-1.0.0-alpha2, +vartheme_bs5-5.0.0-alpha3
rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes
rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes
rajab natshah’s picture

rajab natshah
he/him
commented
Assigned: alamgir.hossain.cse » josebc
Status: Closed (fixed) » Needs review
rajab natshah’s picture

rajab natshah
he/him
commented
Assigned: josebc » mohammed j. razem
rajab natshah’s picture

rajab natshah
he/him
commented
Title: Rename Horizontal Ruler Component to Divider component » Rename the Horizontal Ruler component to Divider component
rajab natshah’s picture

rajab natshah
he/him
commented
Assigned: mohammed j. razem » Unassigned
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes

✅ Released vartheme_bs5-5.0.0-alpha3

rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes

✅ Released varbase_starter-1.0.0-alpha2

rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes

✅ Released varbase-11.0.0-alpha3