The footer type selector in the theme settings form lists components by name only (e.g. "Footer Two Columns"), with no indication of which theme they belong to. Since artisan_starterkit ships inside the contrib module and subthemes are generated from it, both the original starterkit components and the subtheme copies share identical names. This means duplicate, indistinguishable options appear in the selector even on a standard single-subtheme setup, before considering sites with multiple subthemes active.
The discovery logic in ArtisanCustomizations::themeSettingsAlter() (src/ArtisanCustomizations.php) scans all active themes via ComponentPluginManager::getAllComponents(), filters by group: Artisan Footer, and uses $component->metadata->name as the select option label with no theme context included.
Source of the component mus be displayed in the footer type selector.
| Comment | File | Size | Author |
|---|
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
frouco commentedImplementation has been completed.
Ready for review.
Comment #4
omarlopesinoThe MR looks good to me. I added a suggestion (skippable if you disagree). It needs fixing the conflicts before reviewing.
Comment #5
omarlopesinoSkipped the skippable suggestion and marked to merge.