Problem/Motivation

GitLab pipeline has problems that should be fixed

Link to the pipeline with errors
https://git.drupalcode.org/project/menu_export/-/jobs/7039155

Issue fork menu_export-3589663

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

o_timoshchuk created an issue. See original summary.

o_timoshchuk changed the visibility of the branch 3589663-fix-the-phpstan to hidden.

o_timoshchuk changed the visibility of the branch 3589663-fix-the-phpstan to active.

o_timoshchuk opened merge request !20

o_timoshchuk’s picture

o_timoshchuk commented
Assigned: o_timoshchuk » Unassigned
Status: Active » Needs review

The PHPStan issues have been resolved. The module was successfully tested following the updates.

https://git.drupalcode.org/project/menu_export/-/jobs/9858593

foxy-vikvik’s picture

foxy-vikvik commented

I have create a reparate issue related to the changes https://www.drupal.org/project/menu_export/issues/3591775

foxy-vikvik’s picture

foxy-vikvik commented
Related issues: +#3591775: Refactor export/import logic into a service for the MenuImport and MenuExport functions
o_timoshchuk’s picture

o_timoshchuk commented
Assigned: Unassigned » o_timoshchuk
o_timoshchuk’s picture

o_timoshchuk commented
Assigned: o_timoshchuk » Unassigned
Status: Needs review » Fixed

Merged. Thanks, @foxy-vikvik. Good job

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.