Problem/Motivation

Add tugboat support for easier manual review and testing in issues

https://www.drupal.org/docs/develop/git/using-git-to-contribute-to-drupa...

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork canvas_entity_reference-3589500

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

  • 3589500-add-tugboat Comparechanges, plain diff MR !3
    • 1 hidden branch
  • 1.0.x Comparecompare
About issue forks

Comments

anybody created an issue. See original summary.

anybody opened merge request !3

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Issue summary: View changes
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Active » Needs review
zeeshan_khan’s picture

zeeshan_khan commented
Status: Needs review » Needs work
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs work » Needs review

Thanks @zeeshan_khan sorry! Fixed!

zeeshan_khan’s picture

zeeshan_khan commented

PR looks good to me and approved but it needs rebase!
Only minor suggestion
The config runs composer require drupal/canvas_entity_reference and then pm:enable canvas_entity_reference but never explicitly enables Canvas itself.
If Canvas is listed as a dependency in composer.json, Composer will download it, but Drush's pm:enable won't auto-enable it. The Tugboat preview may end up with the module failing to enable because Canvas isn't enabled first.

If you want the preview to actually work, add: vendor/bin/drush --yes pm:enable canvas before the canvas_entity_reference enable line. But that's upto you to fix if the preview doesn't work — it doesn't affect the module.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

@zeeshan_khan That's not totally correct. It's auto-enabled trough the .info.yml dependency: https://git.drupalcode.org/project/canvas_entity_reference/-/blob/1.0.x/...

Just try the Tugboat link above in this issue!

So I think you may RTBC this once tested yourself.

zeeshan_khan’s picture

zeeshan_khan commented

Sorry my bad!
I will merge it once you rebase the branch - "Fast forward merge is not possible. Please rebase or use merge train."

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Done! :)

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

PS: Credits welcome! :)

anybody changed the visibility of the branch 1.0.x to hidden.

  • zeeshan_khan committed 64276a77 on 1.0.x authored by anybody 
    fix: #3589500 Add tugboat support for easier manual review and testing...
zeeshan_khan’s picture

zeeshan_khan commented
Status: Needs review » Reviewed & tested by the community

Sure thing!
Thanks for the contribution

  • zeeshan_khan committed 64276a77 on issue/3589499-x-entity-type-bundles-tests-and-docs authored by anybody 
    fix: #3589500 Add tugboat support for easier manual review and testing...
zeeshan_khan’s picture

zeeshan_khan commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.