Problem/Motivation
lumora_theme and lumora_canvas had accumulated dead code: unused base-theme components with no callers, canvas components disabled in the recipe with no unique value, and three canvas components
that duplicated render logic already present in the base theme. Additionally, the table, list, and list_row SDC components existed but were never wired to Drupal template overrides, making them
effectively uncallable. The recipe.yml contained ~30 stale disable: entries referencing components that never existed on disk.
Proposed resolution
- Remove 9 uncalled base-theme components: accordion, avatar_group, badge, divider, drawer, loading, modal, progress, tooltip
- Remove 4 dead canvas components: tabs, tab, layout, layout_columns
- Convert 3 canvas standalone renderers to proper delegates: breadcrumbs, menu, language_select now call lumora_theme:* via include(..., with_context: false)
- Add views-view-table.html.twig, views-view-list.html.twig, and item-list.html.twig template overrides wiring lumora_theme:table/list to Drupal's template system
- Add timeline and timeline_item components to both lumora_theme (slot-based) and lumora_canvas (flat-prop canvas wrappers)
- Clean up ~30 stale disable: entries in recipe.yml
Remaining tasks
- Review and merge feature/component-cleanup branch
- Run composer update && drush cr on staging and verify home page renders correctly
- Follow-up: forwarding row.attributes/column.attributes in views-view-table.html.twig requires adding an attributes prop to table_row/table_cell (tracked separately)
Issue fork lumora_theme-3588687
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
zemike commentedComment #4
zemike commented