Problem/Motivation

There is a security advisory for firebase/php-jwt below version 7, see https://github.com/advisories/GHSA-2x45-7fc3-mxwq

Steps to reproduce

Proposed resolution

Bump the version constraint from ^6.0 to ^7.0 and make sure, that the module still works with the newer version.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork zoom_video-3588299

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

  • 1.x Comparechanges, plain diff MR !13
About issue forks

Comments

jurgenhaas created an issue. See original summary.

tostinni made their first commit to this issue’s fork.

tostinni opened merge request !13

tostinni’s picture

tostinni commented
Status: Active » Needs review

Here is a simple bump to 7.x verison of php-jwt.
Doing so should work flawlessly as the only place where it is used is here:
src/ZoomMeetingSDKRequest.php

  public function generateJwt(array $payload, string $secret): string {
    return JWT::encode($payload, $secret, 'HS256');
  }

And the zoom sdk_secret are exactly 32 bytes which is the minimum now required by php-jwt, so this seems fine.

danmer’s picture

danmer commented
Status: Needs review » Fixed

Merged, closing the issue

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.