Problem/Motivation

\Drupal\ckeditor5_plugin_pack\Utility\LibraryVersionChecker does a some work in the constructor. The YAML parsing for core.libraries.yml is slow. 32 ms in my benchmark.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 3587746-1.patch2.14 KBwebflo

Issue fork ckeditor5_plugin_pack-3587746

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

webflo created an issue. See original summary.

webflo’s picture

webflo commented
Status: Active » Needs review
StatusFileSize
new 3587746-1.patch2.14 KB

32 ms down to 23 µs

salmonek’s picture

salmonek commented
Status: Needs review » Reviewed & tested by the community

Hi Florian

Thank you for the update. We'll have a release probably next week, with your patch included.

salmonek opened merge request !43

  • salmonek committed b331d75a on 1.5.x authored by webflo 
    Issue #3587746: Avoid YAML parsing, cache CKE version in cache.discovery
salmonek’s picture

salmonek commented
Status: Reviewed & tested by the community » Fixed

Released in 1.5.3

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.