Problem/Motivation

NodeQueryAlterTest performs no drupalGet() or similar calls other than a single drupalLogin(). It can trivially be converted to a kernel test.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3587705

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review

longwave opened merge request !15615

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

I've been trying to find something to comment on and couldn't. The changes are pretty simple. I didn't find anything else that looked like it needed to be changed or removed. I naively wondered if maybe the hooks involved could be migrated into the test now that it's a Kernel test, but no. The node_access_test module is used in a bunch of other tests. So I have nothing more to say about it. It looks good to me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work

Needs a reroll.

acbramley made their first commit to this issue’s fork.

acbramley’s picture

acbramley commented
Status: Needs work » Reviewed & tested by the community

Rebased

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 0423130b3cb to main and 1c358731421 to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • alexpott committed 1c358731 on 11.x 
    task: #3587705 NodeQueryAlterTest should be a kernel test

By: longwave...

  • alexpott committed 0423130b on main 
    task: #3587705 NodeQueryAlterTest should be a kernel test

By: longwave...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.