Problem/Motivation

There's an error on the configuration page when the "Additional host" setting has no hosts listed.
Also, the name is misleading since you'll need to include the host name of the site if you want the Tidy process to update it. It's more like "All host names to treat as being the same as this site"

Undefined array key 0

Steps to reproduce

The default configuration doesn't include any hosts in the list, so this happens on install :(
If you've already added at least one host name Load a configuration with an empty aka_host setting.

Proposed resolution

The configuration page should not result in an error when aka_host is empty. There are two parts to update

  • Include a 'web' host name in the default install (base_uri is 'https://web/', so it's a good example/hint)
  • Fix the error on the setting page

User interface changes

Updated the text on the setting page and in the schema.yml.

Test

If you install Link Magician with the updated branch there will be an example in the default configuration. Remove the host 'web', save the configuration and reload.

CommentFileSizeAuthor
buildAkaHosts-undefined-array-key-0.png27.51 KBjasongose
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

jasongose created an issue. See original summary.

jasongose’s picture

Title: Error on configuration page when akahost is empty » Error on configuration page when aka_host is empty
jasongose’s picture

Issue summary: View changes

jasongose’s picture

Issue summary: View changes
jasongose’s picture

Status: Active » Needs review

revathi.b made their first commit to this issue’s fork.

jasongose changed the visibility of the branch 3587509-error-on-configuration to hidden.

jasongose changed the visibility of the branch 3587509-error-fix to hidden.

jasongose changed the visibility of the branch 3587509-error-fix to hidden.

jasongose changed the visibility of the branch 3587509-error-on-configuration to active.

Fixed a similar error for the URL Path Skip option.

terracoders’s picture

Status: Needs review » Reviewed & tested by the community

Changing status to Reviewed & Tested

jasongose’s picture

Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

jasongose’s picture

Status: Fixed » Closed (fixed)