Problem/Motivation

The current set-up takes a long time to complete on a webform with thousands of submissions - it will likely error out from surpassing the server's max_execution_time or memory_limit.

Steps to reproduce

Enable IP deletion as a Form Bulk Operation in /admin/structure/webform/config.
Select a webform and choose "Delete collected IP addresses" in the operations dropdown.
Site will error if too many submissions.

Proposed resolution

Switch to using a direct database deletion and then invalidating the cache of the webform submissions. This also helps avoid sending emails, which would not be expected for an update like this.

Remaining tasks

Review.

User interface changes

API changes

Data model changes

Issue fork webform_ip_delete-3587367

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

andileco created an issue. See original summary.

andileco changed the visibility of the branch 3587367- to hidden.

andileco opened merge request !1

andileco’s picture

andileco commented
Status: Active » Needs review
andileco’s picture

andileco commented
Issue summary: View changes
nikathone’s picture

nikathone
Primary language Swahili
Location Ontario
commented
Status: Needs review » Reviewed & tested by the community

Checked the code and they looks good.

andileco’s picture

andileco commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.