Hello, everyone. Welcome to the :sparkle: CLI in Core Initiative :sparkle: Meeting! :calendar: This meeting:
➤ Usually happens weekly either at Wednesday 14:00 UTC or Wednesday 22:00 UTC.
➤ Will start synchronously for 30 minutes with an open agenda.
➤ Will then switch to threads to continue discussions.
➤ Please comment on the roll call thread throughout the day.

0️⃣ Roll Call! Who is here today? Introduce yourself including your name and drupal.org username. If you feel comfortable, share what command you are excited about adding or refactoring.

mradcliffe Synchronous attendees: tekNorah, moshe weitzman, franksj, mradcliffe
mott Ryan Mott (u/rymo) and I can't live without uli 💙
dww Derek, dww. Living in the Hawaiian Kingdom. uli and cr are probably my 2 most used commands, followed by cim and cex, but sqlc is another favorite. :nerd_face:
bircher bircher yes I also use cex and cim a lot and uli also.. and scr

1️⃣ CLI entry point in Drupal core —#3453474: CLI entry point in Drupal Core
1️⃣ 0️⃣ Issue Status.

mradcliffe moshe added the logger support, refactored bootstrappable commands already in core.moshe and mradcliffe resolved backwards-compatibility issue and tests.mradcliffe worked on symfony/runtime dependency https://www.drupal.org/node/3313404 and updated this issue to version 8.0.8. That issue currently has random test failures that may.mradcliffe created a draft change record with contrib module developer recommendations for namespacing.Waiting on @longwave to review moshe’s answers to items.We talked about what it would take to get to Needs review.(edited)

1️⃣ 1️⃣ Install command description.

mradcliffe We agreed that the current description is too long for commands. moshe suggested using synopsis to encapsulate the existing warning about the command not being usable for anything other than demo sites.
moshe :checked:

1️⃣ 2️⃣ larowlan’s review comment about \Drupal. (edited)

mradcliffe We discussed it being difficult to make DrupalApplication container aware, but moshe would look into how hard that was going to be.Also the ContentExportCommand uses the container directly to get aliased services by class name, which could be refactored as an example of how to autowire services with dependency injection in a bootstrapped command.
larowlan I think this is follow up material if it requires jumping through hoops
larowlan lets focus on getting it in and done
moshe The DrupalApplication usage of Drupal::getContainer() is now gone. I moved the event subscriber into own class, which uses autowire. ContentExportCommand has been fixed as well to use autowire.

2️⃣ CLI in Core Meta Issue — https://www.drupal.org/node/3582246
2️⃣ 0️⃣ Miscellaneous meeting stuff

mradcliffe I created the meeting notes from last week and smustgrave reviewed and resolved the issue.

2️⃣ 1️⃣ Spreadsheet and prioritized commands.

mradcliffe We talked about whether we need to bring in prioritized commands from the spreadsheet into the meta issue. We agreed that this was not necessary.

2️⃣ 2️⃣ Translation / Multilingual support

mradcliffe @Mile23 did some research on multilingual support in an older issue. The way that Drupal Console did it was custom. We talked about difficulties on this, and agreed to add it as maybe Phase 4 or later in the initiative.

2️⃣ 3️⃣ Meeting availability

mradcliffe Moshe unavailable next week. Matthew is available.
bircher next week is also dev days, who is in Athens?
mradcliffe Repeating bircher’s question from the thread, Will anyone be at Dev Days in Athens this week?

3️⃣ Name the new CLI entry point —#3583795: [policy, no patch] Decide naming the new CLI entry point to dr
3️⃣ 0️⃣ There is consenus growing to not use drupal but use something like pal

mradcliffe The issue summary could use some improvement to help analyze what is good about what option and why. Maybe a table?
dww pal is clever, but poses a serious pronunciation problem. :nerd_face::joy: is it like you say the English word for friend (like the first syllable in “palatable”)? Or is it more like you pronounce the 2nd syllable in “Drupal”, more like the English word “pall”?
mott we have precedence for that! I never got past drUHsh vs drOOsh :smiling_face_with_tear:
dww Well, yeah, good point. :laughing: It's OBViously drUHsh, but we don't pronounce it Druh-pul, either. :nerd_face: Clearly it's Droo-pall. for better and for worse.
mott My suggestion of drup wasn't going to fare any better :smile:I do like that pal breaks the muscle memory. If the command starts with dru I'm surely typing sh next by reflex for a long time
larowlan I still type docker composer so agree muscle memory is a thing
moshe The objections to pal have been pretty trivial IMO. @mott I think you can proceed with the rename. My one reminder is that core/scripts/drupal should continue to work for BC.
mradcliffe The problem is that you cannot rename the script that gets binned so this would either require a fork or a composer plugin.
mradcliffe By fork I mean a copy of the script.
mradcliffe Keeping a separate copy has the maintenance issues from the original mr and a composer plugin to either alias or allow renaming might be a lot of work.
dww For the record, I was totally joking about a “serious problem”. I'm definitely +1 on pal
bircher I am going to alias whatever we are going to call it to dr like I currently do for drush...
bircher but I don't really understand why drupal is not good
moshe drupal is very good. We have one name that many people like even more.
mradcliffe @mott I think you have a backwards-compatible way forward on the rename now in the issue.
mott I struggled for a bit on whether everything that was renamed from "dex" to "drupal" needed to be touched again. A lot of the class renames went to "console" and I think in most cases it makes sense to align on that generic term. The one miss is "DexModuleCommandDiscovery" to "DrupalModuleCommandDiscovery" and I propose we make that "ConsoleCommandDiscovery" for clarity of purpose and parity with ConsoleCompilerPass. DrupalApplication and DrupalConsoleLogger keep the prefix as both would shadow Symfony names otherwise. After that, renaming the binary and replacing references was pretty straightforward. Once we land on "dr" or "pal" I'm ready to push code.
mradcliffe I think the only change is to copy drupal to dr and create a new drupal that's backwards-compatible.
mott yes! your shim is included in that :+1:
mott pushed.
bircher @mott why did you rename it to dr I didn't mean to suggest that we should call it that, that is my alias :smile: I think drupal or pal are much better...
mradcliffe I think jwilson3 pushed it over the edge with the arguments about two-letter commands being standard.
mradcliffe I re-opened the naming issue back to Needs review, @bircher.
moshe I also think drupal and pal are better.
mott I have a playbook ready to run to switch the name again if needed when that issue resolves.

Participants:

tekNorah, franksj, moshe weitzman, mradcliffe, rymo, dww, bircher, larowlan

Comments

mradcliffe created an issue. See original summary.

smustgrave’s picture

smustgrave commented
Status: Needs review » Fixed

Assigned credit to the users mentioned above.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.