Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork poll-3586410

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ivnish created an issue. See original summary.

ivnish opened merge request !88

ivnish’s picture

ivnish
he/him
commented
Assigned: ivnish » Unassigned
Status: Active » Needs review
berdir’s picture

berdir
Primary language German
Location Switzerland
commented

drive-by-note: I just don't bother running phpstan on anything but the default branch, it's usually tedious to keep it happy on multiple core branches since depending on how you configure it I guess, it also complains if something that's ignored isn't actually happening.

I also opened an issue to ignore those attributes directly in the drupal phpstan integration, because LegacyHook and similar ones will eventually go away but you'll still want to keep the for BC.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

  • bramdriesen committed f7cf349f on 2.0.x authored by ivnish 
    feat: #3586410 Improve phpstan ignore "LegacyHook" and "Hook" for Drupal...
bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

> it also complains if something that's ignored isn't actually happening

Yeah, that usually happens if you have a baseline file. Drives me crazy on our projects :D

Merged.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.