Problem/Motivation

For whatever reason, I removed the settings form element for "identify_users_on_login" in #3500561: Identify / Synchronize anonymous users client / server side and created an update hook to clear that config through an update hook.

The problem is, that config is still used in code and also has an existing schema entry.

Steps to reproduce

Proposed resolution

Discuss why it was removed and whether we should bring it back.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork posthog-3586186

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

grevil created an issue. See original summary.

grevil’s picture

grevil commented

Discussed this with @anybody internally and we both think the setting and the login hook is not needed (anymore).

Identifying the user server side doesn't give us any advantage anymore, since we sync the user distinct id between php and js. When the user is identified js side, a posthog user profile is created. If the user later on uses one of the posthog php commerce events, the very same user distinct id already used in js is passed to the php capture call.

We should make posthog_php require posthog_js, add a notice on the posthog_php settingsform, that the php extension requires cookies to identify the user properly and remove the login hook.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: Unassigned » grevil
Status: Active » Needs work

Confirmed! Happy to review later.

grevil’s picture

grevil commented
Assigned: grevil » Unassigned
Status: Needs work » Needs review

grevil opened merge request !51

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

RTBC! Just two final comments, then let's merge this!

  • grevil committed c3a3df36 on 2.x 
    feat: #3586186 "identify_users_on_login" setting form element missing
grevil’s picture

grevil commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

grevil’s picture

grevil commented

Oh, just saw, that the tests throws an error "Unfinished AJAX requests while tearing down a test". I'll fix that in another issue!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.