Problem/Motivation

/admin/config/services/posthog form can not be saved
Clicking save the console says: "Das ungültige Formularsteuerelement mit name='ui_host' ist nicht fokussierbar."

Probably because it's marked as required?

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork posthog-3586056

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anybody created an issue. See original summary.

anybody opened merge request !50

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Active » Needs review

Seems the reason is that the conditions for "required" are also checking by OR!
So one is always valid xD

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Let's see if !in works, never tried that...

Otherwise we may need a different syntax for AND

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Nice, this works in Tugboat!

Should we add a functional JS test to ensure that for the future or are we fine?

@grevil after review please merge and tag a new release then once everything is fixed. Thanks!

grevil’s picture

grevil commented
Status: Needs review » Reviewed & tested by the community

LGTM!

I don't think we need a test.

  • grevil committed 0e618781 on 2.x authored by anybody 
    feat: #3586056 /admin/config/services/posthog form can not be saved  By...
grevil’s picture

grevil commented
Assigned: grevil » Unassigned
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.