Problem/Motivation

------ -----------------------------------------------------------------------
Line src/UriExtractor.php
------ -----------------------------------------------------------------------
41 No error with identifier method.unresolvableReturnType is reported on
line 41.
🪪 ignore.unmatchedIdentifier (non-ignorable)
------ -----------------------------------------------------------------------
------ -----------------------------------------------------------------------
Line src/UrlExtractor.php
------ -----------------------------------------------------------------------
56 No error with identifier method.unresolvableReturnType is reported on
line 56.
🪪 ignore.unmatchedIdentifier (non-ignorable)
------ -----------------------------------------------------------------------

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork twig_tweak-3585973

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anybody created an issue. See original summary.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Title: Fix phpstan » Fix phpstan and phpunit (3.x + 4.x)

Fix phpstan and phpunit (3.x + 4.x)

anybody opened merge request !84

anybody opened merge request !85

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Also see https://git.drupalcode.org/project/twig_tweak/-/merge_requests/86 and merge before, if it (partially) works

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

If there's too much broken in 3.x that's already fixed in 4.x let's simply release 4.0.0.

  • anybody committed 1a93e8cb on 3.x 
    feat: #3585973 Fix 3.x phpunit (cherry-pick from 4.x) By: anybody
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Nice, I was able to fix phpunit through cherry-picks in https://git.drupalcode.org/project/twig_tweak/-/merge_requests/86 for 3.x

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Active » Needs work
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

@grevil let's not forget about this one before next release.

grevil’s picture

grevil commented
Assigned: grevil » Unassigned
Status: Needs work » Closed (duplicate)

These issues are already solved through #3585972: Move missing issue commits from 3.x to 4.x and clarify difference between 4.x and 3.x.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.