Problem/Motivation

With #3585693 GitLab CI support has beed added. The pipeline now reports some PhpCS and PhpStan issues. These should be fixed.

Steps to reproduce

See pipeline

Proposed resolution

Fix issues.

Issue fork xsl_formatter-3585702

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jocowood created an issue. See original summary.

jocowood opened merge request !10

jocowood’s picture

jocowood
Primary language German
Location Kamp-Lintfort
commented
Status: Active » Needs review

Merge request ready, move forward to "Needs review"

tvalimaa’s picture

tvalimaa commented

There couple place where you use LoggerChannelFactory class instead of LoggerChannelFactoryInterface which is in the constructor

like * @param \Drupal\Core\Logger\LoggerChannelFactoryInterface $loggerFactory
but LoggerChannelFactory $loggerFactory

jocowood’s picture

jocowood
Primary language German
Location Kamp-Lintfort
commented

Thank you tvalimaa for your support. Your changes looking good, although these are no PhpStan or -Cs fixes :-)

Now we need a third person to review our changes.

jocowood changed the visibility of the branch 3585702 to hidden.

harkonn’s picture

harkonn commented
Status: Needs review » Fixed

Thank you for your help everyone :)

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.