Problem/Motivation

Support for Link fields would be similar to handling src (in <img>) and href (in <a>) and feels like something Link Magician should do :)

Proposed resolution

Add support.

User interface changes

Adds configuration settings for 'Link field' in the Media Lookup Order section and Not Published section.

Tracking changes

This introduces data that looks a bit different in the current before/after (link_magician_link table) and tag (link_magician_skip) fields in tracking.

Test

You need to have at least one AKA configured ("https://example.net" used below; don't forget to click the save button).
You'll need to have a content type that supports the Link field (if you're adding it in a testing environment, I'd recommend setting it to allow multiple)
You'll also need to have/create

  1. A media entity with an alias; for example /testing/media
  2. a page with an alias: for example /testing/page

Create/edit a page to include several variations of the page and media links (replace NNN/MMM the node/media ids for the above) in Link Fields

  1. /testing/media
  2. entity:media/MMM
  3. https://example.net/testing/media
  4. /testing/page
  5. https://example.net/testing/page

Run link magician on the parent page: drush link_magician:tidy nodeid --nodeid=NNNN
See the "Updated" results (/admin/link_magician/tracking/results/updated/{batchid}). You should see updates to the links.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

jasongose created an issue. See original summary.

jasongose’s picture

Issue summary: View changes

jasongose’s picture

Issue summary: View changes
jasongose’s picture

Status: Active » Needs review

jasongose’s picture

Issue summary: View changes
cameron prince’s picture

Status: Needs review » Reviewed & tested by the community

All tests pass. Noting I did have to add my local domain name in both the base URI and the Additional hosts inputs on the config form.
Setting RTBC.

jasongose’s picture

Status: Reviewed & tested by the community » Fixed

Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

jasongose’s picture

Status: Fixed » Closed (fixed)