Problem/Motivation

The call to $entity->getAttributeNames() only works on php 8.3+ and php 8.1 is still supported for Drupal 10

Steps to reproduce

Either install this on a Drupal 10 site w/ php 8.1.x *or* have a look at the pipeline results for 'phpstan (previous major)'

Resolution

The composer and info files for Link Magician have been updated to require php 8.3 (which was recently dropped from "Active support", but still has over a year of security support ... Please consider be updating to php 8.4 or better yet, php 8.5!)

Issue fork link_magician-3584824

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jasongose created an issue. See original summary.

jasongose’s picture

jasongose commented
Priority: Normal » Minor

I'd really suggest that sites upgrade to 8.3+; that said, maybe the "fix" here is to require 8.3 in the info.yml

jasongose opened merge request !6

jasongose’s picture

jasongose commented
Issue summary: View changes

At the time I'm writing this, there's one bit of code you'd need to change in order to make it 8.1 compatible (src/Service/Utility.php:1504)

$attributes = $elem->getAttributeNames();
jasongose’s picture

jasongose commented
Status: Active » Fixed

Fixed (by explicitly requiring php 8.3+)

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

jasongose’s picture

jasongose commented
Status: Fixed » Closed (fixed)