Problem/Motivation

A collection of small improvements to improve the robustness of the 2.1.x branch.

1. Ensure we pass integers to \Drupal\node_revision_delete\NodeRevisionDeleteBatch::previousRevisionDeletionBatch()
2. Avoid division by zero if nodes are deleted while we are populating the queue
3. Do not allow negative number of revisions in the form as it makes no sense.

Proposed resolution

Tweak the code to fix these things.

Remaining tasks

User interface changes

New minimum on a form element

API changes

None

Data model changes

None

Issue fork node_revision_delete-3584706

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexpott created an issue. See original summary.

alexpott opened merge request !69

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review

  • alexpott committed f6cd1853 on 2.1.x 
    task: #3584706 Small improvements

By: alexpott
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

alexpott closed merge request !69

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.